Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Topics in popup to mute unrelated topics #502

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

kevkevinpal
Copy link
Collaborator

This adds a new feature of the topics table which you can mute and unmute topics

Screenshot 2023-10-17 at 10 02 07 AM
Screenshot 2023-10-17 at 10 02 17 AM

Copy link
Collaborator Author

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking functional but is ugly. Minor suggestions for code fixes

package.json Show resolved Hide resolved
try {
await putNodeData({ ref_id: refId, node_name: 'muted_topic', node_value: shouldMute })

// setSources(data.filter((i) => i.ref_id !== id))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to update the sources after hitting mute as it should be gone


return !data?.length ? (
<Flex>
<Text>There is not any results for selected filters</Text>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this text is incorrect

Comment on lines +54 to +62
{i.muted_topic ? (
<IconWrapper className="centered" onClick={() => handleMute(i.ref_id, false)}>
<MdCheckCircle color={colors.primaryGreen} fontSize={24} />
</IconWrapper>
) : (
<IconWrapper className="centered" onClick={() => handleMute(i.ref_id, true)}>
<MdCancel color={colors.primaryRed} fontSize={24} />
</IconWrapper>
)}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks messy I should fix it

src/constants/index.ts Outdated Show resolved Hide resolved
@kevkevinpal kevkevinpal merged commit acc7d0c into stakwork:master Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant