-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added Topics in popup to mute unrelated topics #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking functional but is ugly. Minor suggestions for code fixes
try { | ||
await putNodeData({ ref_id: refId, node_name: 'muted_topic', node_value: shouldMute }) | ||
|
||
// setSources(data.filter((i) => i.ref_id !== id)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to update the sources after hitting mute as it should be gone
|
||
return !data?.length ? ( | ||
<Flex> | ||
<Text>There is not any results for selected filters</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this text is incorrect
{i.muted_topic ? ( | ||
<IconWrapper className="centered" onClick={() => handleMute(i.ref_id, false)}> | ||
<MdCheckCircle color={colors.primaryGreen} fontSize={24} /> | ||
</IconWrapper> | ||
) : ( | ||
<IconWrapper className="centered" onClick={() => handleMute(i.ref_id, true)}> | ||
<MdCancel color={colors.primaryRed} fontSize={24} /> | ||
</IconWrapper> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks messy I should fix it
3cfaef3
to
af8ed68
Compare
This adds a new feature of the topics table which you can mute and unmute topics